Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow easier testing #680

Merged
merged 1 commit into from
Aug 11, 2018
Merged

Allow easier testing #680

merged 1 commit into from
Aug 11, 2018

Conversation

F43nd1r
Copy link
Member

@F43nd1r F43nd1r commented Jul 2, 2018

  • allow mulitple init calls
  • do not catch errors (especially AssertionErrors)

@mikehardy you might be interested in the ACRATest class, as it serves as an example on how to test reports.

@F43nd1r F43nd1r added this to the acra-5.2.0 milestone Jul 2, 2018
@mikehardy
Copy link
Contributor

Very interesting - I'm nowhere near ACRA-experienced enough to comment on the Throwable->Exception change but the multiple init and test example is useful, thank you! This may help shepherd ankidroid/Anki-Android#4893 through a merge if the primary maintainer there is hesitant, and then after it will help with a ReportLimiter integration as it shows more how to trigger ACRA programmatically. Much appreciated

@F43nd1r F43nd1r merged commit ee4d82b into ACRA:master Aug 11, 2018
@F43nd1r F43nd1r deleted the test branch September 8, 2018 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants