Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File attachment support #560

Merged
merged 17 commits into from
Mar 25, 2017
Merged

File attachment support #560

merged 17 commits into from
Mar 25, 2017

Conversation

F43nd1r
Copy link
Member

@F43nd1r F43nd1r commented Mar 11, 2017

Resolve #558
Resolve #561

@F43nd1r F43nd1r changed the title File attachmetn support (experimental) File attachment support (experimental) Mar 11, 2017
@F43nd1r
Copy link
Member Author

F43nd1r commented Mar 13, 2017

@MFlisar I've updated the project with a builtin content provider for all standard directories. So you'd only need a custom ContentProvider for non-file content.

@MFlisar
Copy link

MFlisar commented Mar 13, 2017

I'll check that tomorrow. Only thing to take care of is, I would not use this provider. It's unsafe, other apps could access all files that the app which is using ACRA can access.

I think, the default one in acra should only allow to access files in a cache folder, for safety reasons even only for files in a sub acra folder...

@F43nd1r
Copy link
Member Author

F43nd1r commented Mar 13, 2017

The content provider is not exported. Only apps called by ACRA will receive temporary permissions for exactly the files in the intent.

@MFlisar
Copy link

MFlisar commented Mar 13, 2017

Oh, then it's fine. I've not seen that...

@F43nd1r
Copy link
Member Author

F43nd1r commented Mar 13, 2017

Android takes care of the security management. That is the only reason to use content uris over file uris in this usecase.

@F43nd1r F43nd1r changed the title File attachment support (experimental) File attachment support Mar 22, 2017
@F43nd1r F43nd1r merged commit 61e846a into ACRA:master Mar 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants