Simplified Collectors #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Created by Lukas on 12.08.2016. | ||
| */ | ||
| public class CustomDataColletor extends Collector { |
|
Definitely need to keep USER_CRASH_DATE as it says when the crash actually happened. |
| * | ||
| * @return priority of this collector | ||
| */ | ||
| public int getPriority() { |
There was a problem hiding this comment.
Why do we need a priority?
If a Collector is configured then it should be called.
There was a problem hiding this comment.
That was meant to provide control over the execution order to the collectors, but it is probably overengineering to do so.
Ok, backwardscompatibility is probably more important than the negligible improvement of sending two strings less. |
|
Resolved merge conflicts (rebase onto master) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no standard way to talk to a Collector. Every collector sort of does its own thing: Some are static, some require an instance and every call has different parameters.
This aims at standardizing all these collectors, which greatly reduces the code inside CrashReportDataFactory.
While it might look differently, this actually doesn't change any of the underlying logic, it just cleans it up.
However I noticed we ignore some of the configuration: While it makes sense to always send the Stacktrace and a report id, I think IS_SILENT, USER_APP_START_DATE and USER_CRASH_DATE do not qualify for an always-include and should be optional.