read logcat logs in nonblocking mode with end timeout

[c-romeo]

I encounter and issue with handleSilentException and ReportField.LOGCAT on Lenovo TAB 2 A8-50F.
It appears that when an ProgressDialog is shown a lot of useless info are spitted to the logs and ACRA spends couple of minutes to receive logs and send report due the fact that reading from InputStream is done in a blocking way.

I think is better to have at least an empty log info than a lots of useless logs due the fact that Stream is blocked for writing.

Also for my particular context handling ACRA's sending exception in another thread helped me, and received some info due the fact ProgressDialog is closed immediately after.
new Thread(new Runnable() { @Override public void run() { ACRA.getErrorReporter().handleSilentException(e); } }).start();
the_culprit.txt

[william-ferguson-au]

What version of ACRA was this for?

[c-romeo]

I reproduce it with version 4.8.5 / 4.9.0 rc 2; not sure about 4.6.3, a user reported similar behaviour but I didn't investigated than

[c-romeo]

Patch was tested with 4.9.0 rc 2

[william-ferguson-au]

Doesn't this mean that it will always block for 3 seconds?

[c-romeo]

Yes, I've added a read timeout limit. Not sure if this should be exposed to ACRAConfiguration.
In my tests if timeout was reached in few seconds I received on remote server logs with empty logcat field.

[c-romeo]

And if a developer don't want any delay on main / exception thread, acra's work should be done in a separate thread. For the moment I use a helper method in which I use a Runnable and start a new thread; again, not sure if a queue should be use.

[william-ferguson-au]

My point is, is that it's not a timeout.
This read will block for exactly 3 seconds regardless of whether there is any log to read.

[c-romeo]

good point. this is the fix
if ((line = nonBlockingReader.readLine()) != null) { if (filter.apply(line)) { buffer.add(line); } } else { break; }

[william-ferguson-au]

NB when you submit a pull request, always submit it from a branch so that you don't risk polluting it with any other changes you might make.

[c-romeo]

This means that I should do something next?

[F43nd1r]

If this runs into timeout, will the newest or the oldest logs miss?

BTW: I wouldn't name this method Async, because this normally means that it returns asynchronous. Something more descriptive like NonBlocking would fit better.

I also think this might not be a good idea as default, maybe an opt-in option for it would be better.

[c-romeo]

If runs in timeout it will

• be missing all the log (most of my cases, and I'm very happy with the fix even if reports lacks of logcat logs I still receive callstack, custom fields...)
• or if aggressive logging will start while acra receive some logs only the oldest will be sent.

[F43nd1r]

I just checked out your master for testing purpose. It does not compile. I think you forgot to commit the addition of local attributes in ACRAConfiguration and ConfigurationBuilder.

[c-romeo]

Fixed