Make ACRAConfiguration final

src/main/java/org/acra/collector/CrashReportDataFactory.java

@@ -42,8 +42,8 @@
 import java.util.GregorianCalendar;
 import java.util.HashMap;
 import java.util.LinkedHashMap;
-import java.util.List;
 import java.util.Map;
+import java.util.Set;
 import java.util.UUID;
 
 import static org.acra.ACRA.LOG_TAG;
@@ -167,7 +167,7 @@ public String getCustomData(@NonNull String key) {
     public CrashReportData createCrashData(@NonNull ReportBuilder builder) {
         final CrashReportData crashReportData = new CrashReportData();
         try {
-            final List<ReportField> crashReportFields = config.getReportFields();
+            final Set<ReportField> crashReportFields = config.getReportFields();
 
             // Make every entry here bullet proof and move any slightly dodgy
             // ones to the end.

src/main/java/org/acra/collector/DropBoxCollector.java

@@ -28,6 +28,7 @@
 import java.util.Calendar;
 import java.util.List;
 import java.util.Locale;
+import java.util.Set;
 
 import static org.acra.ACRA.LOG_TAG;
 
@@ -72,9 +73,9 @@ public String read(@NonNull Context context, @NonNull ACRAConfiguration config)
             if (config.includeDropBoxSystemTags()) {
                 tags.addAll(Arrays.asList(SYSTEM_TAGS));
             }
-            final String[] additionalTags = config.additionalDropBoxTags();
-            if (additionalTags.length > 0) {
-                tags.addAll(Arrays.asList(additionalTags));
+            final Set<String> additionalTags = config.additionalDropBoxTags();
+            if (additionalTags.size() > 0) {
+                tags.addAll(additionalTags);
             }
 
             if (tags.isEmpty()) {

src/main/java/org/acra/collector/LogCatCollector.java

@@ -29,7 +29,6 @@
 
 import java.io.IOException;
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.LinkedList;
 import java.util.List;
 
@@ -79,7 +78,7 @@ public String collectLogCat(@NonNull ACRAConfiguration config, @Nullable String
         // "-t n" argument has been introduced in FroYo (API level 8). For
         // devices with lower API level, we will have to emulate its job.
         final int tailCount;
-        final List<String> logcatArgumentsList = new ArrayList<String>(Arrays.asList(config.logcatArguments()));
+        final List<String> logcatArgumentsList = new ArrayList<String>(config.logcatArguments());
 
         final int tailIndex = logcatArgumentsList.indexOf("-t");
         if (tailIndex > -1 && tailIndex < logcatArgumentsList.size()) {

src/main/java/org/acra/collector/SharedPreferencesCollector.java

@@ -62,8 +62,7 @@ public String collect() {
         sharedPrefs.put("default", PreferenceManager.getDefaultSharedPreferences(context));
 
         // Add in any additional SharedPreferences
-        final String[] sharedPrefIds = config.additionalSharedPreferences();
-        for (final String sharedPrefId : sharedPrefIds) {
+        for (final String sharedPrefId : config.additionalSharedPreferences()) {
             sharedPrefs.put(sharedPrefId, context.getSharedPreferences(sharedPrefId, Context.MODE_PRIVATE));
         }