Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure forceCloseDialogAfterToast to alsoReportToAndroidFramework #438

Merged
merged 2 commits into from
Apr 28, 2016
Merged

Restructure forceCloseDialogAfterToast to alsoReportToAndroidFramework #438

merged 2 commits into from
Apr 28, 2016

Conversation

F43nd1r
Copy link
Member

@F43nd1r F43nd1r commented Apr 20, 2016

Perform as noted in #421 (comment)

@william-ferguson-au
Copy link
Member

Would much prefer alsoReportToAndroidFramework than alsoReportToNative.

Yes, it's shorter, but native is more often connected with native libraries and we already get enough confusion from native lib users expecting ACRA to catch segfaults.

@F43nd1r
Copy link
Member Author

F43nd1r commented Apr 20, 2016

OK, got it.

@F43nd1r F43nd1r changed the title Restructure forceCloseDialogAfterToast to alsoReportToNative Restructure forceCloseDialogAfterToast to alsoReportToAndroidFramework Apr 20, 2016
@william-ferguson-au william-ferguson-au merged commit 2f9f255 into ACRA:master Apr 28, 2016
@F43nd1r F43nd1r deleted the report_native branch May 4, 2018 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@F43nd1r @william-ferguson-au