Add configuration for dialog theme #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to add something to the Wiki for this as well. |
|
It was removed :( Well, I'm not updating to 4.8.5 in this case. I just tried to do it and got frustrated. |
|
@indywidualny I don't understand your comment. Can you please elaborate? |
|
@william-ferguson-au Oops. Sorry, I was not clear. I tried to update to 4.8.5 today because I'm using 4.7.0 now. It was not possible to choose a dialog theme (with the code above). I found this commit and found out it's not included to the latest release yet. So I'm waiting untill a new version is released and decided not to update to 4.8.5 now. |
|
4.9.0-RC-1 has been released. |
|
Great! It was weird for me that theming dialogs worked before and now didn't. But this RC brought it back so I'm glad to hear it. Good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default theme (Theme.Dialog) is not anymore up-to-date. Giving an easy option to change this and make the dialog look better and more fitting seems reasonable.