New implementation for getCurrentProcessName #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (ACRA.DEV_LOGGING) log.d(LOG_TAG, "ACRA processName='" + processName + "'"); | ||
| return (processName != null) && processName.equals(ACRA_PRIVATE_PROCESS_NAME); | ||
| return (processName != null) && processName.endsWith(ACRA_PRIVATE_PROCESS_NAME); |
There was a problem hiding this comment.
WHy change this from equals to endsWidth? equals is much more precise.
There was a problem hiding this comment.
I noticed that when run on an 6.0 device, the process name is prepended with the package name. (I haven't tested on other versions, this might just be normal for the new getCurrentProcessName.)
There was a problem hiding this comment.
OK, just add an inline comment to that effect so that we know why when looking at it later.
|
I rebased this onto master to remove duplicated commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perform #424 (comment)
adapted from http://stackoverflow.com/a/21389402/4388512
Also: made DEV_LOGGING non-final. Developers might want to change this wihle testing their app. (It was made final by me in the first place in one of the automated passes.)
Depends upon #426