Followup #396
Merged
Followup #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 14, 2016 14:53
william-ferguson-au
added a commit
that referenced
this pull request
Mar 16, 2016
Further cleanup from @F43nd1r
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed some annotations in #389, that's why they are here. Same goes for typos in #390 .
Removed an unnecessary context reference, see https://github.com/F43nd1r/acra/commit/1cb7f2318147bf1992ee66d69978cb5d8e15b4ed#commitcomment-16677096
Replaced boxed values with primitives, see #390 (comment)