Reports are sent via the SenderService in a separate process. #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y default) started in another process. ReportSenders are now configured via configuring ReportSenderFactory classes in ErrorReporter (NB this is a BREAKING API change).
Moving CrashReport* classes to org.acra.common package.
…s#reportSenderFactoryClasses.
william-ferguson-au
added a commit
that referenced
this pull request
Jan 4, 2016
SendWorker now works in the separate process service.
william-ferguson-au
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an enhanced version of #329
And fixes the issue in #327
It introduces SenderService that performs all report sending and by default performs it in another process (which avoids the problems with OKHttp trying to start a Thread while the VM is shutting down).
It doesn't enable the UncaughtExceptionHandler for ACRA if the current process is the SenderService. This avoids infinite loop crashes on start.
It allows declarative or programmatic config of ReportSenderFactories.
NOTE: It has a BREAKING API change in ErrorReport for config of ReportSenders, because you need to provide a ReportSenderFactory CLASS rather than a ReportSender instance so that we can correctly configure the SenderService.