Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Dialog easier to extend #341

Merged
merged 1 commit into from
Jan 3, 2016
Merged

Make Dialog easier to extend #341

merged 1 commit into from
Jan 3, 2016

Conversation

F43nd1r
Copy link
Member

@F43nd1r F43nd1r commented Dec 19, 2015

I liked the default dialog, but I wanted to apply minimal changes to it. That is currently very hard. In my implementation (note: no logic changed) I have several Methods which can be overridden to modify just parts of the dialog:

  • addViewToDialog can be used to add view to the start (call before buildCutomView) or end of the dialog (call after buildCustomView)
  • getMainView, getCommentPrompt and getEmailPrompt allow to modify or replace specific parts of the dialog
  • buildAndShowDialog can be used to e.g. prevent the creation of the dialog in certain situations
  • getDialog for more modifications to the dialog (e.g third button)

These allow more modifications than I would need, but I thought it will help in the future if it is more flexible.

william-ferguson-au added a commit that referenced this pull request Jan 3, 2016
Make Dialog easier to extend
@william-ferguson-au william-ferguson-au merged commit 68b01cf into ACRA:master Jan 3, 2016
@william-ferguson-au
Copy link
Member

Thanks @F43nd1r excellent addition.

@F43nd1r F43nd1r mentioned this pull request Mar 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants