Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move logcat collection to prevent pollution during crash data gathering #339

Merged
merged 1 commit into from
Dec 16, 2015

Conversation

chkwok
Copy link
Contributor

@chkwok chkwok commented Dec 16, 2015

Moved logcat collection to a much earlier point in crash data collection so it is not polluted by messages generated by data collection. Some ROMs leave verbose messages on for Settings, that generates 2 lines per variable read and overwrites the whole 100 lines default logcat buffer. Example on an Acer S57 on 4.4.4:

12-16 00:33:21.564 V/Provider/Settings(29238): get setting for user 0 by user 0 so skipping cache
12-16 00:33:21.564 V/Provider/Settings(29238): from db cache, name = wifi_display_qe_on , value = 1
12-16 00:33:21.564 V/Provider/Settings(29238): get setting for user 0 by user 0 so skipping cache
12-16 00:33:21.565 V/Provider/Settings(29238): from db cache, name = wifi_display_max_resolution , value = 0
12-16 00:33:21.565 V/Provider/Settings(29238): get setting for user 0 by user 0 so skipping cache
12-16 00:33:21.565 V/Provider/Settings(29238): from db cache, name = wifi_display_change_resolution_remind , value = null
12-16 00:33:21.565 V/Provider/Settings(29238): get setting for user 0 by user 0 so skipping cache
12-16 00:33:21.566 V/Provider/Settings(29238): from db cache, name = wifi_display_security_option , value = 1

…ion so it is not polluted by messages generated by data collection. Some ROMs leave verbose messages on for Settings, that generates 2 lines per variable read and overwrites the whole 100 lines default logcat buffer.
william-ferguson-au added a commit that referenced this pull request Dec 16, 2015
Move logcat collection to prevent pollution during crash data gathering
@william-ferguson-au william-ferguson-au merged commit a6660ae into ACRA:master Dec 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants