Silent reports are not silent

[gkamperis]

ACRA 5.1.1 + 5.1.2
(migrating from 4.8.2)

Hi,

I have setup ACRA with a custom dialog class and a toast resource id after a sending a report.

Upon startup in the MainActivity onCreate() I do
ACRA.getErrorReporter().handleSilentException(new Exception("TEST"));

This causes my custom dialog and the sent confirmation toast to appear.
My custom dialog shows fine and the report is received.

The issue is that the report is not silent.
Neither the dialog or the toast should be shown.

If I postDelay the silent report for 5000msec the dialog is not shown and I get only the toast.

This did not happen with ACRA 4.8.2
Reports were indeed silent.

CONFIGURATION

       @AcraDialog(reportDialogClass = CustomLogActivity.class)
       @AcraCore(reportFormat = StringFormat.JSON,
               buildConfigClass = XXXX,
               reportContent = {
               },
               resReportSendSuccessToast = R.string.crash_report_msg,
               logcatArguments = {"xxx", "xxx"}
       )
       public class SomeApp extends Application {
       ...
       }

       @Override
       protected void attachBaseContext(Context base) {
       super.attachBaseContext(base);
       CoreConfigurationBuilder builder = new CoreConfigurationBuilder(this)
                .setReportContent(xxxx)
                .setExcludeMatchingSharedPreferencesKeys(xxx)
                .setBuildConfigClass(BuildConfig.class)
                .setReportFormat(StringFormat.JSON);

        builder.getPluginConfigurationBuilder(HttpSenderConfigurationBuilder.class)
                .setUri(xxx)
                .setBasicAuthLogin(xxx)
                .setBasicAuthPassword(xxx)
                .setHttpMethod(HttpSender.Method.PUT)
                .setEnabled(true);
        ACRA.init(this, builder);        
}

[F43nd1r]

Looks like a race condition between SenderServiceStarter.startService and ApplicationStartupProcessor.approveOneReport.
Fixed it by ignoring just created reports in the startupprocessor.

[gkamperis]

Thanks for the quick response.

I assume this race starts after the call to handleSilentException() because even if I delay the sending 10sec after app start I still get the toast.

Does your comment mean that the report will be completely ignored and I need to find a way to send it differently?

Will your fix handle the toast as well?
Any idea of when this will be released? or can I try the fix?

Sorry about all the questions... :)

[F43nd1r]

Does your comment mean that the report will be completely ignored and I need to find a way to send it differently?

No. It was handled twice, which was the problem. Now one ignores it, the other handles it (silently).

Will your fix handle the toast as well?

No. These Toasts are currently unaffected by silent mode. This could probably be enhanced.

Any idea of when this will be released?

As we just had a release, it might be some time, although It'll probably won't take longer than a month.

or can I try the fix?

you can always compile from source: clone the branch with the fix and run the gradle task publishToMavenLocal

[gkamperis]

So just to clarify... Even though the notification is silent the toast will still appear?
In 4.8.2 there was no toast for a silent report

[F43nd1r]

Are you talking about the toast interaction or the reportSendSuccess/Failure toast?

[gkamperis]

I am talking about the report send success... I don't use the toast interaction

[F43nd1r]

Yes, currently the toast will always be shown. But I agree that this is a shortcoming and will likely change in the next version.

…

On 22 Mar 2018 15:06, "GKA" ***@***.***> wrote: I am talking about the report send success... I don't use the toast interaction — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#654 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJxxpE9qAZ6FzM2gUz8ea-aNtsJ-nXJoks5tg6_lgaJpZM4S2Kos> .

[gkamperis]

My vote goes for changing it... :)

For me personally it is a "breaking change" in behaviour.
Is there a workaround maybe? (apart from disable it all together and show manually)

The migration page helped a lot with going from 4.8 to 5.1 but didn't see any mention of breaking changes.

Is there another page that lists these?

Thanks again for your help

[F43nd1r]

Except for the notification module, there shouldn't be any breaking changes in behaviour, only in configuration.

I'm afraid there is no workaround, but you can use the attached snapshot.
acra-core-5.1.3-SNAPSHOT.zip

[gkamperis]

Thanks again for your help and for the snapshot..
I went with "disable it all together and show manually"...
Does the snapshot implement the PR?

[F43nd1r]

Yes