Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain somewhere that WAKE_LOCK permission has maxSdkVersion attribute #651

Closed
sarbyn opened this issue Mar 9, 2018 · 4 comments
Closed

Comments

@sarbyn
Copy link
Contributor

sarbyn commented Mar 9, 2018

In my project I use the WAKE_LOCK permission and when I've upgrating ACRA to the latest version the application has stop working.
After some research I found the
<uses-permission android:name="android.permission.WAKE_LOCK" android:maxSdkVersion="25" />
in acra-core AndroidManifest.xml and then I've changed my project manifest with:
<uses-permission android:name="android.permission.WAKE_LOCK" tools:node="replace"/>

I think that it's better to declare somewhere in the install guide that acra-core add the maxSdkVersion, in order to warn the developer that something weird can happen with his application

@F43nd1r
Copy link
Member

F43nd1r commented Mar 15, 2018

Now part of the new Troubeshooting guide

@mikehardy
Copy link
Contributor

I see this in the troubleshooting guide now but this did trip me up, along with the ':acra' android:process need for the crash process item. So I'm not disputing that they are documented, but I think they are important enough (especially that WAKE_LOCK one!) that there should be an AndroidManifest.xml section in Basic Setup now, as otherwise the need to modify the manifest isn't even mentioned but it can result in crash bugs so easily

@F43nd1r
Copy link
Member

F43nd1r commented Sep 13, 2018

As of 5.2.0 this is a non-issue, see #690

@mikehardy
Copy link
Contributor

Thus must have just caught me prior to 5.2.0 when we were on 5.1, thanks. Might still be worth it to mention the process name but that isn't likely a crash bug... Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants