add comment, fix policy

ACRA · May 20, 2016 · a580e72 · a580e72
1 parent 2422236
commit a580e72
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/main/java/org/acra/config/DefaultRetryPolicy.java b/src/main/java/org/acra/config/DefaultRetryPolicy.java
@@ -20,13 +20,13 @@
 import java.util.List;
 
 /**
- * Default {@link RetryPolicy}. Do not resend reports if at least one sender completed.
+ * Default {@link RetryPolicy}. Only resend if all senders failed.
  * @author F43nd1r
  * @since 4.9.0
  */
 public class DefaultRetryPolicy implements RetryPolicy {
     @Override
     public boolean shouldRetrySend(List<ReportSender> senders, List<FailedSender> failedSenders) {
-        return senders.size() > failedSenders.size();
+        return senders.size() == failedSenders.size();
     }
 }
diff --git a/src/main/java/org/acra/config/RetryPolicy.java b/src/main/java/org/acra/config/RetryPolicy.java
@@ -27,6 +27,12 @@
  * @since 4.9.0
  */
 public interface RetryPolicy {
+
+    /**
+     * @param senders a list of all senders
+     * @param failedSenders a list of all failed senders with the thrown exceptions
+     * @return if the request should be resent later
+     */
     boolean shouldRetrySend(List<ReportSender> senders, List<FailedSender> failedSenders);
 
     class FailedSender {