Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Kotlin 2.1.10 #654

Merged
merged 17 commits into from
Feb 17, 2025
Merged

Upgrade to Kotlin 2.1.10 #654

merged 17 commits into from
Feb 17, 2025

Conversation

dpad85
Copy link
Member

@dpad85 dpad85 commented Nov 18, 2024

This PR upgrades the project to Kotlin 2. It supersedes #628.

  • kotlin updated to v2.1.10
  • SKIE updated to v0.10.1

We also switch to the direct integration technique which is the standard and also fixes a build issue on some Xcode versions.

@dpad85
Copy link
Member Author

dpad85 commented Nov 18, 2024

Note, to manage dependency versions we also switched to the toml version catalog instead of the buildSrc technique. See ACINQ/lightning-kmp#727 for reference about the choice made.

@dpad85 dpad85 mentioned this pull request Nov 18, 2024
@dpad85 dpad85 force-pushed the kotlin-2.0-alt-direct-integ branch from d17a751 to 083af38 Compare December 12, 2024 14:24
@dpad85 dpad85 force-pushed the kotlin-2.0-alt-direct-integ branch from 083af38 to 1444d0d Compare February 10, 2025 14:59
@dpad85
Copy link
Member Author

dpad85 commented Feb 10, 2025

Rebased on #671 (remove legacy) which itself includes #662 (remove Tor embedded lib).

@dpad85 dpad85 force-pushed the kotlin-2.0-alt-direct-integ branch from 1444d0d to 92caf39 Compare February 10, 2025 15:13
@dpad85 dpad85 changed the title Upgrade to Kotlin 2.0.21 Upgrade to Kotlin 2.1.10 Feb 13, 2025
dpad85 and others added 5 commits February 13, 2025 16:51
These workaround should be now fixed with kotlin 2.
- secp: 0.14.0 -> 0.17.1
- ktor: 2.3.13 -> 3.1.0

A few androidx libraries have also been updated.
@dpad85 dpad85 force-pushed the kotlin-2.0-alt-direct-integ branch from f4154ae to c246351 Compare February 14, 2025 16:27
Some UI elements have been broken with this updated and need to be fixed.
@dpad85 dpad85 marked this pull request as ready for review February 14, 2025 18:13
@dpad85 dpad85 requested a review from robbiehanson February 14, 2025 18:13
@robbiehanson robbiehanson self-requested a review February 14, 2025 21:24
@dpad85 dpad85 merged commit 59ae125 into master Feb 17, 2025
@dpad85 dpad85 deleted the kotlin-2.0-alt-direct-integ branch February 17, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants