Relay onion messages #2061
Merged
Relay onion messages #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@t-bast Not ready yet but does the way I use actors look good? |
t-bast
reviewed
Nov 10, 2021
eclair-core/src/main/scala/fr/acinq/eclair/io/MessageRelay.scala
Outdated
Show resolved
Hide resolved
eclair-node/src/main/scala/fr/acinq/eclair/api/handlers/Message.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/io/MessageRelay.scala
Outdated
Show resolved
Hide resolved
thomash-acinq
force-pushed
the
onion-messages
branch
4 times, most recently
from
c8a5960 to
92cf397
Compare
Codecov Report
@@ Coverage Diff @@
## master #2061 +/- ##
==========================================
+ Coverage 87.54% 87.60% +0.05%
==========================================
Files 165 166 +1
Lines 12688 12717 +29
Branches 536 545 +9
==========================================
+ Hits 11108 11141 +33
+ Misses 1580 1576 -4
|
t-bast
reviewed
Nov 12, 2021
eclair-core/src/main/scala/fr/acinq/eclair/io/MessageRelay.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/io/MessageRelaySpec.scala
Outdated
Show resolved
Hide resolved
thomash-acinq
force-pushed
the
onion-messages
branch
from
e1752a1 to
7399078
Compare
pm47
reviewed
Nov 26, 2021
eclair-core/src/main/scala/fr/acinq/eclair/io/MessageRelay.scala
Outdated
Show resolved
Hide resolved
pm47
reviewed
Nov 26, 2021
eclair-core/src/main/scala/fr/acinq/eclair/remote/EclairInternalsSerializer.scala
Outdated
Show resolved
Hide resolved
thomash-acinq
force-pushed
the
onion-messages
branch
from
4c8bd39 to
ac61c53
Compare
t-bast
reviewed
Nov 26, 2021
eclair-core/src/test/scala/fr/acinq/eclair/io/MessageRelaySpec.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Pierre-Marie Padiou <pm47@users.noreply.github.com>
thomash-acinq
force-pushed
the
onion-messages
branch
from
473ad4e to
1942b4c
Compare
* Use typed actor framework for MessageRelaySpec * Fix port conflicts in integration tests * Use pipeTo instead of blocking for integration tests * Increase timeout for integration spec * Add tests for user content tlvs * Add tests for automatic reconnection
t-bast
approved these changes
Nov 29, 2021
There was a problem hiding this comment.
Good job, LGTM 🚀
With this new API it should be easy to test onion messages against other implementations, have you been able to test with rusty's latest updates for c-lightning?
If we're compatible (again) it's an important milestone, it will be worth mentioning on the onion messages spec PR!
|
I've tested it ElementsProject/lightning#4921 can relay messages between eclair nodes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually relay onion messages and add API to send onion messages.
Follows #1957