Refactor codecs and onion types #2057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Relay onion messages - Add functions to create onion messages
* Refactor MessageOnion.scala to match PaymentOnion.scala * Add documentation * Rename `RecipientSecret` to `PathId` * Fix `publickey` codec to be fixed length (33 bytes) * Add sealed trait for `DropReason` * Revert `OnionRoutingPacket` codec change
|
Why did you revert the |
thomash-acinq
force-pushed
the
onion-messages
branch
from
dbcd4a9 to
1c3b039
Compare
|
Thanks, merged it in #1957. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RecipientSecrettoPathIdpublickeycodec to be fixed length (33 bytes)DropReasonOnionRoutingPacketcodec change