htlc post restart 4 #1586
Merged
htlc post restart 4 #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `cleanupRelayDb` accepts `htlcsIn: Seq[IncomingHtlc]` instead of `channels: Seq[HasCommitments]`. - `remoteOutgoingToLocalIncoming` method is extracted from `getIncomingHtlcs` (will be reused in HC plugin).
- `cleanupRelayDb` accepts `htlcsIn: Seq[IncomingHtlc]` instead of `channels: Seq[HasCommitments]` (to account for plugins). - `remoteOutgoingToLocalIncoming` method is extracted from `getIncomingHtlcs` (will be reused in HC plugin).
akumaigorodski
commented
Nov 5, 2020
akumaigorodski
commented
Nov 5, 2020
eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/PostRestartHtlcCleaner.scala
Outdated
Show resolved
Hide resolved
t-bast
reviewed
Nov 5, 2020
eclair-core/src/main/scala/fr/acinq/eclair/channel/Channel.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/payment/Auditor.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/PostRestartHtlcCleaner.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/PostRestartHtlcCleaner.scala
Outdated
Show resolved
Hide resolved
| @@ -540,7 +540,7 @@ class ApiServiceSpec extends AnyFunSuite with ScalatestRouteTest with IdiomaticM | |||
| system.eventStream.publish(chcr) | |||
| wsClient.expectMessage(expectedSerializedChcr) | |||
|
|
|||
| val chsc = ChannelStateChanged(system.deadLetters, system.deadLetters, bobNodeId, OFFLINE, NORMAL, null) | |||
| val chsc = ChannelStateChanged(system.deadLetters, null, system.deadLetters, bobNodeId, OFFLINE, NORMAL, null) | |||
There was a problem hiding this comment.
What's nice is that now we'll be able to easily add the channelId here! It's not your job to do it in this PR though, I'll do it in a follow-up one.
Yes, |
akumaigorodski
commented
Nov 6, 2020
t-bast
reviewed
Nov 6, 2020
eclair-core/src/main/scala/fr/acinq/eclair/channel/Channel.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelTypes.scala
Outdated
Show resolved
Hide resolved
eclair-node-gui/src/main/scala/fr/acinq/eclair/gui/GUIUpdater.scala
Outdated
Show resolved
Hide resolved
eclair-node-gui/src/main/scala/fr/acinq/eclair/gui/GUIUpdater.scala
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1586 +/- ##
==========================================
+ Coverage 87.25% 87.33% +0.08%
==========================================
Files 145 146 +1
Lines 11056 11056
Branches 479 471 -8
==========================================
+ Hits 9647 9656 +9
+ Misses 1409 1400 -9
|
t-bast
reviewed
Nov 6, 2020
eclair-core/src/test/scala/fr/acinq/eclair/payment/PostRestartHtlcCleanerSpec.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/payment/PostRestartHtlcCleanerSpec.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/payment/PostRestartHtlcCleanerSpec.scala
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/payment/PostRestartHtlcCleanerSpec.scala
Outdated
Show resolved
Hide resolved
t-bast
reviewed
Nov 6, 2020
eclair-core/src/test/scala/fr/acinq/eclair/payment/PostRestartHtlcCleanerSpec.scala
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/payment/PostRestartHtlcCleanerSpec.scala
Outdated
Show resolved
Hide resolved
t-bast
approved these changes
Nov 9, 2020
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1586 +/- ##
==========================================
+ Coverage 87.25% 87.33% +0.08%
==========================================
Files 145 146 +1
Lines 11056 11056
Branches 479 471 -8
==========================================
+ Hits 9647 9656 +9
+ Misses 1409 1400 -9
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is continuation of #1580 (rather than wrestling with git I've decided to send a new PR). It follows suggestions outlined in 9d63b94.