Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

access-om2: pass type to depends_on() #127

Merged
merged 1 commit into from
Jul 7, 2024
Merged

access-om2: pass type to depends_on() #127

merged 1 commit into from
Jul 7, 2024

Conversation

harshula
Copy link
Collaborator

@harshula harshula commented Jul 5, 2024

@harshula harshula requested a review from CodeGat July 5, 2024 13:00
@harshula harshula self-assigned this Jul 5, 2024
@harshula harshula merged commit c5e1a5c into main Jul 7, 2024
1 check passed
harshula added a commit that referenced this pull request Jul 8, 2024
@harshula
access-om2: pass type to depends_on() (#127)
11bc73e 
* Passing type="run" to help with module autoloading as per:
  https://spack.readthedocs.io/en/v0.22.0/module_file_support.html#autoloading-and-hiding-dependencies
@harshula
Copy link
Collaborator Author

harshula commented Jul 9, 2024

There was a bug in the code that was reviewed. It was an exact copy of the access-om2-bgc SBD and I had not removed type=ACCESS-OM-BGC. I noticed the bug in the pre-release build and force pushed the fix so that we could start another pre-release build quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeGat CodeGat CodeGat approved these changes

Assignees

@harshula harshula

Labels
None yet
Projects
ACCESS-OM2 Spack
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshula @CodeGat