Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common/modules.yaml: remove ACCESS-OM2 specific include list #39

Merged
merged 1 commit into from
Jul 5, 2024
Merged

common/modules.yaml: remove ACCESS-OM2 specific include list #39

merged 1 commit into from
Jul 5, 2024

Conversation

harshula
Copy link
Collaborator

@harshula harshula commented Jul 5, 2024

  • The ACCESS-OM2 environment's spack.yaml will contain the include list.

@harshula
common/modules.yaml: remove ACCESS-OM2 specific include list
2c6b551 
* The ACCESS-OM2 environment's spack.yaml will contain the include list.
@harshula harshula requested a review from CodeGat July 5, 2024 01:15
@harshula harshula self-assigned this Jul 5, 2024
CodeGat
CodeGat approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@CodeGat CodeGat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. So this means that by default, we exclude_implicits, but this can be overridden?

@harshula
Copy link
Collaborator Author

harshula commented Jul 5, 2024

My understanding is that spack.yaml can override the default settings.

@harshula harshula merged commit 534bc41 into main Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeGat CodeGat CodeGat approved these changes

Assignees

@harshula harshula

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshula @CodeGat