Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the configuration files to versioned target directories #10

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

harshula
Copy link
Collaborator

  • Add more information to the README
  • Use symlinking of configurations files instead of $SPACK_USER_CONFIG_PATH
  • Use $SPACK_DISABLE_LOCAL_CONFIG to disable ~/spack

@harshula harshula self-assigned this Nov 23, 2023
CodeGat
CodeGat previously approved these changes Nov 23, 2023
Copy link
Contributor

@CodeGat CodeGat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in person.

aidanheerdegen
aidanheerdegen previously approved these changes Nov 23, 2023
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion to make it clear spack-start.bash isn't for general users.

README.md Outdated Show resolved Hide resolved
* Add more information to the README
* Use symlinking of configurations files instead of $SPACK_USER_CONFIG_PATH
* Use $SPACK_DISABLE_LOCAL_CONFIG to disable ~/spack
Copy link
Contributor

@CodeGat CodeGat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those updates were good. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants