-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removal of CI/CD Infrastructure #117
Conversation
17df9fc
to
8973a8a
Compare
a3ea736
to
526923c
Compare
f361035
to
92a62ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good! The small ci.yml
and schedule.yml
especially looks so neat!
Just suggested some very minor edits.
Co-authored-by: jo-basevi <johanna.basevi@anu.edu.au>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Will the |
Might as well! Thanks for the catch :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the CONTRIBUTING.md :) Just two very small comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We are moving the bulk of the CI/CD from the model-specific
access-om2-configs
to a more genericmodel-config-tests
repo. They will be moved via ACCESS-NRI/model-config-tests#24.In this PR:
pr-*
andschedule-*
workflows,parse-ci-config
action frommain
ci.yml
), scheduled checks (schedule.yml
) and modifications toconfig/ci.json
(config.yml
)generate-intial-checksums.yml
to refer to the moved workflow, updated its loggingReferences ACCESS-NRI/model-config-tests#23