Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of CI/CD Infrastructure #117

Merged
merged 13 commits into from
Jun 19, 2024
Merged

Conversation

CodeGat
Copy link
Contributor

@CodeGat CodeGat commented Jun 11, 2024

We are moving the bulk of the CI/CD from the model-specific access-om2-configs to a more generic model-config-tests repo. They will be moved via ACCESS-NRI/model-config-tests#24.

In this PR:

  • Remove pr-* and schedule-* workflows, parse-ci-config action from main
  • Added new workflows for PRs (ci.yml), scheduled checks (schedule.yml) and modifications to config/ci.json (config.yml)
  • Updated generate-intial-checksums.yml to refer to the moved workflow, updated its logging

References ACCESS-NRI/model-config-tests#23

@CodeGat CodeGat force-pushed the model-config-tests-23-remove-infra branch from a3ea736 to 526923c Compare June 11, 2024 23:36
@CodeGat CodeGat force-pushed the model-config-tests-23-remove-infra branch from f361035 to 92a62ea Compare June 13, 2024 01:32
@CodeGat CodeGat marked this pull request as ready for review June 13, 2024 05:13
@CodeGat CodeGat requested a review from jo-basevi June 17, 2024 00:59
jo-basevi
jo-basevi previously approved these changes Jun 18, 2024
Copy link
Collaborator

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! The small ci.yml and schedule.yml especially looks so neat!

Just suggested some very minor edits.

README-DEV.md Outdated Show resolved Hide resolved
README-DEV.md Outdated Show resolved Hide resolved
Co-authored-by: jo-basevi <johanna.basevi@anu.edu.au>
@CodeGat CodeGat requested a review from jo-basevi June 18, 2024 06:08
jo-basevi
jo-basevi previously approved these changes Jun 18, 2024
Copy link
Collaborator

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jo-basevi
Copy link
Collaborator

Will the CONTRIBUTING.md be updated in this PR- here are references to workflows that are now in model-config-tests? https://github.com/ACCESS-NRI/access-om2-configs/blob/main/CONTRIBUTING.md

@CodeGat
Copy link
Contributor Author

CodeGat commented Jun 19, 2024

Might as well! Thanks for the catch :)

Copy link
Collaborator

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the CONTRIBUTING.md :) Just two very small comments

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeGat CodeGat merged commit 0e6c9b6 into main Jun 19, 2024
@CodeGat CodeGat deleted the model-config-tests-23-remove-infra branch June 19, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants