Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply land use changes correctly (and with extra checking) #28

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

MartinDix
Copy link

Fixes problems described in #22.

@MartinDix MartinDix requested a review from blimlim July 5, 2024 00:38
Copy link

@blimlim blimlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me – looks like a lot of detective work. I just added some questions for clarifying a couple of the changes.

One other question that came up while reviewing: update_landuse.py currently has

landuse = xarray.open_dataset('work/atmosphere/INPUT/cableCMIP6_LC_1850-2015.nc').fraction

Will this script be reused for other configurations? I was wondering whether we should remove the hard coded filepath if so.

config.yaml Show resolved Hide resolved
scripts/update_cable_vegfrac.py Show resolved Hide resolved
scripts/update_landuse.py Outdated Show resolved Hide resolved
@MartinDix
Copy link
Author

Changes look good to me – looks like a lot of detective work. I just added some questions for clarifying a couple of the changes.

One other question that came up while reviewing: update_landuse.py currently has

landuse = xarray.open_dataset('work/atmosphere/INPUT/cableCMIP6_LC_1850-2015.nc').fraction

Will this script be reused for other configurations? I was wondering whether we should remove the hard coded filepath if so.

Different land use files would be used for future scenarios. Moved the filename to the driver script so it's passed to the python script as an argument.

@MartinDix MartinDix merged commit 95c66a2 into historical Jul 9, 2024
@MartinDix MartinDix deleted the 22-land-use-change branch July 9, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants