Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add restart reproducibility variant for mom5 #54

Closed
wants to merge 2 commits into from

Conversation

aidanheerdegen
Copy link
Member

Add +restart_repro variant for mom5

Closes #53

Copy link
Contributor

The model version in the spack.yaml has not been updated.
Either update it manually, or comment the following to have it updated and committed automatically:

  • !bump major for feature releases
  • !bump minor for bugfixes

@aidanheerdegen
Copy link
Member Author

I think I've used the right syntax for this, but happy to be told otherwise.

The other option is that we add this as the default variant for the access-om2 SPD. Don't mind either way, but not sure what that would entail.

@aidanheerdegen
Copy link
Member Author

!bump major

Copy link
Contributor

✅ Version bumped from 2023.11.23 to 2024.03.0

@aidanheerdegen
Copy link
Member Author

Bumped the major version because bitwise restart reproducibility represents a significant change in functionality.

@aidanheerdegen
Copy link
Member Author

aidanheerdegen commented Mar 20, 2024

We're going to need to push a new spack-packages version to pick up the updated mom5 SPD right @CodeGat?

ACCESS-NRI/spack-packages@203abec

Edit: and then we'll need to change the version in config:

https://github.com/ACCESS-NRI/ACCESS-OM2/blob/main/config/versions.json#L3

@CodeGat
Copy link
Contributor

CodeGat commented Mar 20, 2024

The Ci is failing because it's not comparing the versions correctly. Haven't dealt with the case as seen here: https://github.com/ACCESS-NRI/ACCESS-OM2/pull/54/files#diff-e8582e74fa156f4e5729a850e52b24f2fde2d815c2c9c360f88c4cf90db851abR13
This will require an update to the CI to fix, but I'll go through the packages.yml syntax. Also with regards to

We're going to need to push a new spack-packages version to pick up the updated mom5 SPD right @CodeGat?

Yes, we will need to. Not only that, we will need to update the version of spack-config in the versions.json as the current one is using spack-start.bash rather than spack-enable.bash @aidanheerdegen

@aidanheerdegen
Copy link
Member Author

No longer required as +restart_repro was made default for mom5

ACCESS-NRI/spack-packages#83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add +restart_repro variant
2 participants