-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add restart reproducibility variant for mom5 #54
Conversation
The model version in the
|
I think I've used the right syntax for this, but happy to be told otherwise. The other option is that we add this as the default variant for the |
!bump major |
✅ Version bumped from |
Bumped the major version because bitwise restart reproducibility represents a significant change in functionality. |
We're going to need to push a new ACCESS-NRI/spack-packages@203abec Edit: and then we'll need to change the version in config: https://github.com/ACCESS-NRI/ACCESS-OM2/blob/main/config/versions.json#L3 |
The Ci is failing because it's not comparing the versions correctly. Haven't dealt with the case as seen here: https://github.com/ACCESS-NRI/ACCESS-OM2/pull/54/files#diff-e8582e74fa156f4e5729a850e52b24f2fde2d815c2c9c360f88c4cf90db851abR13
Yes, we will need to. Not only that, we will need to update the version of |
No longer required as |
Add +restart_repro variant for mom5
Closes #53