Require parallelio 2.5.2

[harshula]

Looking at the COSIMA ACCESS-OM2 source and the git submodules:
https://github.com/COSIMA/access-om2/tree/master/src
https://github.com/COSIMA/cice5/tree/edcfa6f9c76ed05b63196ce4b5355fa5a8f4fe3a
https://github.com/NCAR/ParallelIO/tree/7e242f78bd1b4766518aff44fda17ff50eed6188

we find that COSIMA ACCESS-OM2 uses parallelio 2.5.2, https://github.com/NCAR/ParallelIO/blob/7e242f78bd1b4766518aff44fda17ff50eed6188/CMakeLists.txt#L11-L15:

# The project version number.
set(VERSION_MAJOR   2   CACHE STRING "Project major version number.")
set(VERSION_MINOR   5   CACHE STRING "Project minor version number.")
set(VERSION_PATCH   2   CACHE STRING "Project patch version number.")
mark_as_advanced(VERSION_MAJOR VERSION_MINOR VERSION_PATCH)

I did not require ^parallelio@2.5.2 during my testing. As a result Spack defaulted to parallelio@2.5.10. We should be doing the following from now on:

spack install access-om2 ^netcdf-c@4.7.4 ^netcdf-fortran@4.5.2 ^parallelio@2.5.2 ^nci-openmpi@4.0.2 %intel@19.0.5.281

[aidanheerdegen]

Good catch!

It's a little depressing a newer version degraded performance. This is exactly the sort of situation ("upgrade" downgrading performance) we would want to catch with performance CI checks.

[harshula]

Corrected the instructions at:

• Improved developer experience spack-config#5 (comment)
• https://forum.access-hive.org.au/t/how-to-build-access-om2-on-gadi/1545