Redesign/qtcompatibility #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
July 5, 2023 22:01
…phologica into redesign/qtcompatibility
…le shaders in Visual!
…Programs crash though.
Major changes. As part of this work, I decided to modify the way that VisualModels are set up. Now, instead of passing a shader program in the VisualModel constructor, I set up the access to shaders via a Visual::bindmodel(unique_ptr<VisualModel> vm) call which binds some callbacks and sets a pointer to the parent Visual inside the VisualModel. This is complete for GraphVisual, but lots of plumbing is required yet... Having done this, I have also now figured out how to get a Visual scene rendering in a Qt window! Progress...
…le shaders in Visual!
…Programs crash though.
Major changes. As part of this work, I decided to modify the way that VisualModels are set up. Now, instead of passing a shader program in the VisualModel constructor, I set up the access to shaders via a Visual::bindmodel(unique_ptr<VisualModel> vm) call which binds some callbacks and sets a pointer to the parent Visual inside the VisualModel. This is complete for GraphVisual, but lots of plumbing is required yet... Having done this, I have also now figured out how to get a Visual scene rendering in a Qt window! Progress...
…phologica into redesign/qtcompatibility
…his case, by a QOpenGLWidget
… the GLFW callback handlers, which can be more generic and shared with Qt
… v.shaders, requiring call of v.bindmodel (uptr)
…lable when it is called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges in the new work that I did around making morphologica into a Qt compatible OpenGL drawing system.