-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code restructuring: properly port Braille Extender to Python 3, remove Python 2 idioms and facilities #69
Comments
josephsl
added a commit
to josephsl/BrailleExtender
that referenced
this issue
Jul 16, 2020
As Braille Extender supports NVDA 2019.3 or later (according to manifest), there is no need to keep isPy3 check variable in the add-on anymore, along with Python 2 specific code for imports and such.
josephsl
added a commit
to josephsl/BrailleExtender
that referenced
this issue
Jul 16, 2020
As Python 3 demands Unicode strings by default (unless prefixed by b for bytes), remove unnecessary __futre__.unicode_literals import.
Hi @josephsl,
I think all these are done.
Could you elaborate on this? Perhaps it's better to close this issue and open others. Thanks |
Hi, pretty much most of these are done. Let’s open new issues for others.
From: André-Abush Clause <notifications@github.com>
Sent: Thursday, November 19, 2020 2:38 AM
To: Andre9642/BrailleExtender <BrailleExtender@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Mention <mention@noreply.github.com>
Subject: Re: [Andre9642/BrailleExtender] Code restructuring: properly port Braille Extender to Python 3, remove Python 2 idioms and facilities (#69)
Hi @josephsl <https://github.com/josephsl> ,
* Remove Python 2 checks
* Remove unicode literals import directive
I think all these are done.
* Many more
Could you elaborate on this? Perhaps it's better to close this issue and open others.
Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#69 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4AXEHZA6QHUFGORFXDUBLSQTYQBANCNFSM4O3P245A> .
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
A high priority blocker for #68
Before linting can proceed, it is important to port Braille Extender to Python 3. This is because add-on manifest says NVDA 2019.3 is the minimum supported version, and NVDA Core expects Python 3.7 or later.
The following will be done:
Thanks.
The text was updated successfully, but these errors were encountered: