Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 修复子窗口没有应用透明度的问题 #208

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

A-kirami
Copy link
Owner

@A-kirami A-kirami commented Dec 1, 2024

这个 PR 带来了什么样的更改?

  • 错误修复
  • 新功能
  • 文档/注释
  • 代码格式
  • 代码重构
  • 测试用例
  • 性能优化
  • 外观样式
  • 项目构建
  • 依赖环境
  • 持续集成/部署
  • 其他,请描述:

这个 PR 是否存在破坏性变更?

  • 是的,并已在 issue #___ 号中获得批准
  • 没有

描述

为子窗口正确应用透明度

动机和背景

其他信息

检查工作

  • 我对我的代码进行了注释,特别是在难以理解的部分
  • 我的更改需要更新文档,并且已对文档进行了相应的更改
  • 我添加了测试并且已经在本地通过,以证明我的修复补丁或新功能有效
  • 我已检查并确保更改没有与其他打开的 Pull Requests 重复

@A-kirami A-kirami added the bug Something isn't working label Dec 1, 2024
Copy link

sourcery-ai bot commented Dec 1, 2024

审核指南由 Sourcery 提供

此 PR 通过将适当的不透明类应用于主窗口组件并为关于窗口启用透明度,修复了子窗口中的透明度问题。实现涉及修改窗口布局模板,以根据窗口焦点状态包含条件不透明类,并更新窗口创建配置。

更新的窗口组件类图

classDiagram
    class WindowTitlebar {
        +String class
    }
    class RouterView {
        +String class
    }
    class MainWindow {
        +WindowTitlebar titlebar
        +RouterView view
    }
    MainWindow --> WindowTitlebar
    MainWindow --> RouterView
    note for WindowTitlebar "根据焦点状态更新类的条件不透明度"
    note for RouterView "根据焦点状态更新类的条件不透明度"
Loading

AppSidebarManageButton 更改的类图

classDiagram
    class AppSidebarManageButton {
        +openAbout() : void
    }
    note for AppSidebarManageButton "更新 openAbout 方法以启用关于窗口的透明度"
Loading

文件级更改

更改 详情 文件
根据焦点状态向主窗口组件添加动态不透明类
  • 向 WindowTitlebar 组件添加条件不透明类
  • 向 RouterView 组件添加条件不透明类
  • 为聚焦(40%/60%)和未聚焦(70%/90%)状态实现不同的不透明值
src/layouts/native.vue
添加窗口效果能力权限
  • 将 'core:window:allow-set-effects' 添加到能力列表
src-tauri/capabilities/about.json
启用关于窗口的透明度
  • 在窗口创建配置中添加 transparent: true
src/components/AppSidebarManageButton.vue

提示和命令

与 Sourcery 互动

  • 触发新审核: 在拉取请求中评论 @sourcery-ai review
  • 继续讨论: 直接回复 Sourcery 的审核评论。
  • 从审核评论生成 GitHub 问题: 通过回复审核评论请求 Sourcery 创建问题。
  • 生成拉取请求标题: 在拉取请求标题的任何地方写 @sourcery-ai 以随时生成标题。
  • 生成拉取请求摘要: 在拉取请求正文的任何地方写 @sourcery-ai summary 以随时生成 PR 摘要。您也可以使用此命令指定摘要应插入的位置。

自定义您的体验

访问您的仪表板以:

  • 启用或禁用审核功能,例如 Sourcery 生成的拉取请求摘要、审核指南等。
  • 更改审核语言。
  • 添加、删除或编辑自定义审核说明。
  • 调整其他审核设置。

获取帮助

Original review guide in English

Reviewer's Guide by Sourcery

This PR fixes a transparency issue in child windows by applying proper opacity classes to the main window components and enabling transparency for the about window. The implementation involves modifying the window layout template to include conditional opacity classes based on window focus state and updating window creation configuration.

Class diagram for updated window components

classDiagram
    class WindowTitlebar {
        +String class
    }
    class RouterView {
        +String class
    }
    class MainWindow {
        +WindowTitlebar titlebar
        +RouterView view
    }
    MainWindow --> WindowTitlebar
    MainWindow --> RouterView
    note for WindowTitlebar "Class updated with conditional opacity based on focus state"
    note for RouterView "Class updated with conditional opacity based on focus state"
Loading

Class diagram for AppSidebarManageButton changes

classDiagram
    class AppSidebarManageButton {
        +openAbout() : void
    }
    note for AppSidebarManageButton "openAbout method updated to enable transparency for the about window"
Loading

File-Level Changes

Change Details Files
Added dynamic opacity classes to main window components based on focus state
  • Added conditional opacity classes to WindowTitlebar component
  • Added conditional opacity classes to RouterView component
  • Implemented different opacity values for focused (40%/60%) and unfocused (70%/90%) states
src/layouts/native.vue
Added window effects capability permission
  • Added 'core:window:allow-set-effects' to capabilities list
src-tauri/capabilities/about.json
Enabled transparency for the about window
  • Added transparent: true to window creation configuration
src/components/AppSidebarManageButton.vue

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@A-kirami - 我已经审查了你的更改,它们看起来很棒!

这是我在审查期间查看的内容
  • 🟢 一般问题:一切看起来都很好
  • 🟢 安全性:一切看起来都很好
  • 🟢 测试:一切看起来都很好
  • 🟢 复杂性:一切看起来都很好
  • 🟢 文档:一切看起来都很好

Sourcery 对开源项目免费 - 如果你喜欢我们的审查,请考虑分享它们 ✨
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我将使用反馈来改进你的审查。
Original comment in English

Hey @A-kirami - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

github-actions bot commented Dec 1, 2024

📦️ 此 PR 构建的应用已经准备就绪

平台 文件 大小
🐧 linux-amd64 matcha_0.4.4_linux-amd64 112.71 MB
🍎 macos-amd64 matcha_0.4.4_macos-amd64 24.28 MB
🍎 macos-arm64 matcha_0.4.4_macos-arm64 23.9 MB
🪟 windows-amd64 matcha_0.4.4_windows-amd64 21.94 MB

*从提交 3e9b64f 构建

@A-kirami A-kirami merged commit 6f699d0 into main Dec 1, 2024
7 checks passed
@A-kirami A-kirami deleted the fix/sub-window-transparent branch December 1, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant