Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add base test #3809

Merged
merged 1 commit into from
Jul 28, 2023
Merged

chore: add base test #3809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions .github/workflows/bump.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,20 @@ jobs:
- run: mv temp ./CHANGELOG.md
- run: rm new

- name: Create Pull Request
uses: peter-evans/create-pull-request@v5.0.2
with:
base: main
branch: release
commit-message: 'bump: v${{ steps.get_version.outputs.NEW_VERSION }}'
body: ${{ steps.get_release_note.outputs.result }}
title: 'chore: bump v${{ steps.get_version.outputs.NEW_VERSION }}'
draft: true
milestone: 'v${{ steps.get_version.outputs.NEW_VERSION }}'
# - name: Create Pull Request
# uses: peter-evans/create-pull-request@v5.0.2
# with:
# base: main
# branch: release
# commit-message: 'bump: v${{ steps.get_version.outputs.NEW_VERSION }}'
# body: ${{ steps.get_release_note.outputs.result }}
# title: 'chore: bump v${{ steps.get_version.outputs.NEW_VERSION }}'
# draft: true
# milestone: 'v${{ steps.get_version.outputs.NEW_VERSION }}'
- run: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:10: Double quote to prevent globbing and word splitting [shellcheck]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
"github.head_ref" is potentially untrusted. avoid using it directly in inline scripts. instead, pass it through an environment variable. see https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions for more details [expression]

echo '1' $GITHUB_REF
echo '2' ${{ github.ref }}
echo '3' ${{ github.ref_name }}
echo '4' ${{ github.head_ref }}
echo '5' ${{ github.base_ref }}