Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linux build function #61

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Add linux build function #61

merged 5 commits into from
Sep 11, 2023

Conversation

AtomicFS
Copy link
Collaborator

@AtomicFS AtomicFS commented Sep 1, 2023 •
edited
Loading

  • moved content of coreboot building function into more generic buildWithKernelBuildSystem so that it can be re-used to build Linux kernel too
  • added cross-compilation support
  • added architecture into action.yml to allow cross-compilation
  • tweaked Taskfile.yml to shuffle tests
  • fixed problem with changing directories (test would change current working directory, but not change it back, which would break following test)
  • add option to build container from Dockerfile for local testing

@AtomicFS AtomicFS added feature New feature or request docker docker related github actions labels Sep 1, 2023
@AtomicFS AtomicFS added this to the Refactor the Go action milestone Sep 1, 2023
@AtomicFS AtomicFS force-pushed the feature/go_linux_go branch 3 times, most recently from 6d29d71 to 02f284f Compare September 5, 2023 13:12
@AtomicFS AtomicFS mentioned this pull request Sep 5, 2023
Merged
@AtomicFS AtomicFS force-pushed the feature/go_linux_go branch 4 times, most recently from f57edca to e6f55da Compare September 5, 2023 14:52
@AtomicFS AtomicFS mentioned this pull request Sep 5, 2023
Open
8 tasks
@AtomicFS AtomicFS force-pushed the feature/go_linux_go branch 3 times, most recently from 32afe93 to a772b81 Compare September 5, 2023 15:10
@AtomicFS AtomicFS marked this pull request as ready for review September 6, 2023 09:25
@AtomicFS AtomicFS requested a review from MDr164 September 6, 2023 09:26
@AtomicFS
Copy link
Collaborator Author

AtomicFS commented Sep 6, 2023

@MDr164 Please review approval after #62

@AtomicFS AtomicFS enabled auto-merge September 6, 2023 09:27
MDr164
MDr164 reviewed Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@MDr164 MDr164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a large amount of changes, will have to give it a more thorough round of review when I'm back. The comments I made occur on multiple places around the code, some are quick to change for other we might need to see if they are worth changing at all for now.

action/container/container.go Outdated Show resolved Hide resolved
action/recipes/linux_test.go Outdated Show resolved Hide resolved
action/recipes/coreboot_test.go Outdated Show resolved Hide resolved
action/recipes/linux_test.go Outdated Show resolved Hide resolved
action/recipes/linux_test.go Show resolved Hide resolved
@AtomicFS AtomicFS force-pushed the feature/go_linux_go branch 2 times, most recently from 7ed8219 to 7a7b16b Compare September 6, 2023 12:28
@AtomicFS
Copy link
Collaborator Author

AtomicFS commented Sep 6, 2023

Quite a large amount of changes, will have to give it a more thorough round of review when I'm back. The comments I made occur on multiple places around the code, some are quick to change for other we might need to see if they are worth changing at all for now.

I hope I fixed everything you pointed out.

For now I added a TODO comment about the wget, unxz and gpg2. I am pretty sure there is a library for gpg2.

@AtomicFS AtomicFS force-pushed the feature/go_linux_go branch from 7a7b16b to 583dbb5 Compare September 6, 2023 15:36
@AtomicFS AtomicFS force-pushed the feature/go_linux_go branch from 583dbb5 to 2cc3d7a Compare September 7, 2023 08:49
@AtomicFS AtomicFS requested a review from MDr164 September 7, 2023 08:49
@AtomicFS AtomicFS force-pushed the feature/go_linux_go branch 2 times, most recently from d6efa2b to f7d56bb Compare September 7, 2023 17:09
MDr164
MDr164 reviewed Sep 11, 2023
View reviewed changes
Taskfile.yml Outdated Show resolved Hide resolved
@AtomicFS AtomicFS requested a review from MDr164 September 11, 2023 11:44
MDr164
MDr164 approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@MDr164 MDr164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todos will be tackled later as discussed, so lgtm

@AtomicFS AtomicFS added this pull request to the merge queue Sep 11, 2023
Merged via the queue into main with commit 8966650 Sep 11, 2023
@AtomicFS AtomicFS deleted the feature/go_linux_go branch September 11, 2023 13:52
@AtomicFS AtomicFS added github_actions Pull requests that update GitHub Actions code and removed github actions labels Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDr164 MDr164 MDr164 approved these changes

Assignees
No one assigned
Labels
docker docker related feature New feature or request github_actions Pull requests that update GitHub Actions code module/linux
Projects
None yet
Milestone
Refactor the Go action
Development

Successfully merging this pull request may close these issues.
2 participants
@AtomicFS @MDr164