Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cmd): remove interactivity via SSH #522

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Conversation

AtomicFS
Copy link
Collaborator

@AtomicFS AtomicFS commented Jan 24, 2025

  • Dagger since v0.12 supports much better interactive interface than our make-shift SSH solutions provides
  • as such we are dropping the SSH feature

resolves #239
fixes #269
essentially revert of #147
closes #504 (this was mistake)

- Dagger since v0.12 supports much better interactive interface than our
  make-shift SSH solutions provides
- as such we are dropping the SSH feature

Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
@AtomicFS AtomicFS added go Pull requests that update Go code quality_of_life Improve usage documentation Improvements or additions to documentation labels Jan 24, 2025
Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>
@AtomicFS AtomicFS marked this pull request as ready for review January 24, 2025 15:46
@AtomicFS AtomicFS requested a review from MDr164 as a code owner January 24, 2025 15:46
@AtomicFS AtomicFS enabled auto-merge January 24, 2025 15:46
@AtomicFS AtomicFS added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit a58aa67 Jan 27, 2025
70 checks passed
@AtomicFS AtomicFS deleted the chore/remove-ssh-interactive branch January 27, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation go Pull requests that update Go code module/coreboot module/edk2 module/linux module/stitching module/u-root quality_of_life Improve usage testing Testing related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor to use new dagger 0.12 features
2 participants