Unalias before checking if is interface #3472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Coffman <steve@khanacademy.org>
StevenACoffman
changed the title
Signed-off-by: Steve Coffman <steve@khanacademy.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3471: Use Go 1.22 unalias
When you bind a type with an
Anyscalar field to a go struct where that field is aninterface{}, you have a 50-50 chance you get the generated code with Interface, otherwise Any.This is extremely annoying. Please see #3414 (comment)
This PR does NOT fix that issue, but seems like it's a good precaution.
Signed-off-by: Steve Coffman steve@khanacademy.org