People who use gqlgen as a library get errors following #2598 #3431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Coffman <steve@khanacademy.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2598 there was a slight performance enhancement to cache gqlgen's own packages (such as scalars). However, this used introspective runtime
debug.ReadBuildInfo()to try to figure out what packages those were.The problem for those using gqlgen as a library is that it then would never reload anything.
If you are using a fork of gqlgen (and have modified the go.mod module name) as an executable, it is possible you will have a slight increase in package load times as a result of this change.
Signed-off-by: Steve Coffman steve@khanacademy.org