Skip to content

Commit

Permalink
Update README.md with zip issue
Browse files Browse the repository at this point in the history
- Still trying to figure out why jszip file creation isn't working in Tampermonkey, in the meantime pointing to a newly created issue #2
  • Loading branch information
956MB committed Jan 9, 2025
1 parent 2d348c2 commit 56923d2
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ The browser extension that I've always wanted for Reddit... download buttons for
> This seems to be fixed now (2025-01-08), I guess it was just a bug with Reddit itself? The button should now download individual images in the gallery carousel as intended.
- ~~For some reason the gallery-carousel on Reddit is keeping all the images as visible ("visibility: visible") when clicking forward/back. This is causing all images up to the index you've clicked to be downloaded. Only other method I can see right now of knowing the index is the translate3d value of the gallery-carousel. It's going up/down based on the window width.~~
- The preview download button doesn't work I believe because of the CORS policy.
- ZIP file creation not working when run from Tampermonkey. [Issue #2](https://github.com/956MB/reddit-download-button/issues/2)

## Changelog

Expand Down
2 changes: 0 additions & 2 deletions content.js
Original file line number Diff line number Diff line change
Expand Up @@ -299,8 +299,6 @@
await loadAllImages(gallery);
if (isLightbox) {
gallery.querySelectorAll("li").forEach((li, index) => {
// BUG: (with Reddit NOT code) For some reason the gallery-carousel on Reddit is keeping all the images as visible ("visibility: visible") when clicking forward/back. This is causing all images up to the index you've cliked to be downloaded.
// Only other method I can see right now of knowing the index is the translate3d value of the gallery-carousel. It's going up/down based on the window width.
if (li.style.visibility === "visible" || li.getAttribute('tabindex') === "0") {
const img = li.querySelector("img.media-lightbox-img");
if (img) {
Expand Down

0 comments on commit 56923d2

Please sign in to comment.