Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clippy fixes #167

Merged
merged 10 commits into from
Jul 22, 2024
Merged

chore: clippy fixes #167

merged 10 commits into from
Jul 22, 2024

Conversation

dhilipsiva
Copy link
Contributor

No description provided.

Copy link
Contributor Author

@dhilipsiva dhilipsiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some questions.

packages/network/src/data_plane.rs Outdated Show resolved Hide resolved
packages/network/src/features/pubsub/msg.rs Outdated Show resolved Hide resolved
packages/runner/src/worker_inner.rs Outdated Show resolved Hide resolved
@giangndm
Copy link
Contributor

@dhilipsiva It look like have conflicts after I merge some changes from media-server patch. Can you look at it?

* master:
  chore: disable publish of bin sub-project (8xFF#170)
  chore: update version (8xFF#168)
  refactor: update for media server (8xFF#165)
@dhilipsiva
Copy link
Contributor Author

@giangndm I have carefully resolved all the conflicts and fixed clippy warnings in the media-server patch. If everything looks good to you, we can merge this PR.

Copy link
Contributor

@giangndm giangndm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have some comments and discussions

packages/network/src/base/msg.rs Outdated Show resolved Hide resolved
packages/network/src/features/dht_kv/client/map.rs Outdated Show resolved Hide resolved
packages/network/src/features/dht_kv/mod.rs Outdated Show resolved Hide resolved
packages/network/src/features/dht_kv/server/map.rs Outdated Show resolved Hide resolved
packages/runner/src/history.rs Outdated Show resolved Hide resolved
@giangndm
Copy link
Contributor

@dhilipsiva Cargo-deny is feedback some warns, then we should have some config like media-server has

giangndm
giangndm previously approved these changes Jul 21, 2024
Copy link
Contributor

@giangndm giangndm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for carefully resolved all comments. I will merge it now.

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

Attention: Patch coverage is 79.31034% with 36 lines in your changes missing coverage. Please review.

Project coverage is 83.28%. Comparing base (e3ae359) to head (78dce8c).

Files Patch % Lines
packages/network/src/features/vpn.rs 0.00% 6 Missing ⚠️
packages/network/src/data_plane.rs 37.50% 5 Missing ⚠️
packages/network/src/features/data.rs 55.55% 4 Missing ⚠️
packages/network/src/features/router_sync.rs 73.33% 4 Missing ⚠️
packages/network/src/base/msg.rs 0.00% 3 Missing ⚠️
packages/network/src/features/pubsub/controller.rs 62.50% 3 Missing ⚠️
packages/core/identity/src/node_id.rs 50.00% 2 Missing ⚠️
packages/network/src/features/alias.rs 95.45% 2 Missing ⚠️
packages/network/src/features/pubsub/mod.rs 0.00% 2 Missing ⚠️
packages/core/identity/src/conn_id.rs 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   83.21%   83.28%   +0.06%     
==========================================
  Files          68       68              
  Lines        9038     9016      -22     
==========================================
- Hits         7521     7509      -12     
+ Misses       1517     1507      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giangndm
Copy link
Contributor

@dhilipsiva We have some packages which rejected by cargo-deny, can you create a config for cargo-deny like this:

https://github.com/8xFF/atm0s-media-server/blob/master/deny.toml

@giangndm giangndm merged commit b714e54 into 8xFF:master Jul 22, 2024
10 of 11 checks passed
@giangndm
Copy link
Contributor

@dhilipsiva thank you so much.

@github-actions github-actions bot mentioned this pull request Jul 20, 2024
@dhilipsiva dhilipsiva deleted the clippy-fixes branch July 22, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants