Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to overwrite classnames with service container parameters #35

Merged
merged 2 commits into from
Feb 3, 2016
Merged

Possibility to overwrite classnames with service container parameters #35

merged 2 commits into from
Feb 3, 2016

Conversation

sebastianblum
Copy link

I created the issue #34 (in german) and here is my code proposal.

please give me feedback that I can work on that pull request.
Sebastian

@florianpreusner
Copy link
Member

Cool, didn't know that this is possible.
Checking details later and will provide some feedback.

@florianpreusner
Copy link
Member

Why are you using fake classes instead of mocking?

@sebastianblum
Copy link
Author

I wrote a lot of tests for debugging and then I left these tests.

I don't want to mock the container and before, I used stdClass while debugging.
With the Fake classes I will show, that I can overwrite the class parameter and I will get an instance of that class.

I don't know a better pattern to test that.

florianpreusner pushed a commit that referenced this pull request Feb 3, 2016
Possibility to overwrite classnames with service container parameters
@florianpreusner florianpreusner merged commit c2bb9fa into 8p:master Feb 3, 2016
@florianpreusner
Copy link
Member

👍

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants