Multiple System Tray Icons can be choosen by the user #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update added the method __get_icon_path(), which gets the icon path of the icon based on what is written in the config file.
A combo box with label was added to the settings window. It's located as the last item before the save button in the grid. A validation was added to check if the selected icon image exists.
If new item names need to be added then only the config file has to be edited. I also changed "icon.png" to "color-icon.png".
The monochrome items have sharpen corners, so that the edges appear, because of the lines, less "jagged"
Changed merged two different load_config() into one, which now loads user config and parses value to int into a dictionary. Because values are now always parsed to int, not set Settings in SettingsWindow will now a 0 instead of nothing. This zero can be converted to False for validating the config. I decided for static methods, because the methods don't depend on any object, but just process data. I also changed the icon name Colored Icon to Default Icon
… config.py file. Fixed save after ValidationError. Now it cancels saving process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update added the possibility to select one of multiple system tray icons in the settings window. The icon changes are applied on the next restart of the application.
Fixes # 62
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: