split into core and CLI packages #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There used to be a separate table-layout-cli module but, for the sake of simplicity, the most recent table-layout release merged the two (see the Release Notes). I will take a look at the merits of splitting them up again tomorrow, once I get time.. Thanks for the report. |
|
Oh, interesting. I wasn't aware of that. Thanks for taking a look at this! |
|
Released in v4.0.0, let me know if there's anything else.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I know this is a non-trivial unsolicited PR, but I hope you will find value in it and I would be happy to work to update it to match any preferences you have for.
This creates two packages within this repository: a core package and a CLI package. I would really like to use the core package from a number of projects, but they already have their own CLI libraries and I don't want to pull in additional CLI dependencies that will be unnecessary. This moves the dependencies
command-line-args,command-line-usage, andstream-read-allout of core as well as their transitive dependencies, which is a majority of the project's dependencies: https://npmgraph.js.org/?q=table-layoutThis PR is built using
pnpmso that both projects can be built, tested, etc. with a single command.I would say the main thing to decide is what should the package names be? Some possibilities:
table-layout&table-layout-coretable-layout-cli&table-layouttable-layout&@table-layout/core@table-layout/cli&@table-layout/coreI've also left the version numbers alone, but they would need to be incremented before or as part of any new release.