Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GroupingGetterFunction should be allowed to return arbitrary value #957

Merged
merged 1 commit into from
Dec 29, 2023
Merged

fix: GroupingGetterFunction should be allowed to return arbitrary value #957

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/models/grouping.interface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { GroupingComparerItem } from "./groupingComparerItem.interface";
import { GroupingFormatterItem } from "./groupingFormatterItem.interface";
import { SortDirectionNumber } from "./sortDirectionNumber.enum";

export type GroupingGetterFunction<T = any> = (value: T) => string;
export type GroupingGetterFunction<T = any> = (value: T) => any;
Copy link
Collaborator

@ghiscoding ghiscoding Dec 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now thinking about it and I think it should actually be returning type T when the Generic Type is provided for the item datacontext type (which defaults to any when not provided), it is for the value so that should be the correct type to use. Sorry for asking to change it so many time, I just realized it now 😅

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

damn I think I'm wrong again and this is the value not the datacontext, so it could really be anything


export interface Grouping<T = any> {
/** Grouping Aggregators array */
Expand Down