Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove debounce to avoid horizontal scroll slowness, fixes #789 #803

Closed
wants to merge 1 commit into from
Closed

fix: remove debounce to avoid horizontal scroll slowness, fixes #789 #803

wants to merge 1 commit into from

Conversation

ghiscoding
Copy link
Collaborator

@ghiscoding ghiscoding mentioned this pull request Jun 30, 2023
Closed
@ghiscoding
Copy link
Collaborator Author

@6pac it looks like you pushed a similar commit, but mine also removes the debounce method from the slick.core.js since we no longer need it

@6pac
Copy link
Owner

6pac commented Jun 30, 2023

Sorry, yes just trying to get this release sorted so I added the fix. I thought the debounce method was worth keeping though, there are scenarios where it could be useful. I might just release as is and we can remove the debounce in a future change.

@6pac 6pac closed this Jun 30, 2023
@ghiscoding
Copy link
Collaborator Author

ok go ahead

@6pac
Copy link
Owner

6pac commented Jun 30, 2023

release done. sorry about that, should have posted here before I did the commit - I just thought I'd quickly commit it and push before anyone had a chance to do anything. I have a small window of opportunity.

@ghiscoding ghiscoding deleted the bugfix/debounce-horizontal-scroll-slowness branch September 19, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Progressively slower horizontal scrolling
2 participants
@ghiscoding @6pac