fix(core): rollback PR #497 which is now causing resize issue #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the PR #497 was wrong and should be rolled back since the pre-header height is already calculated by getViewportHeight() which is called in the resizeCanvas() method.
|
just a comment - small amount of whitespace leakage there ... |
|
ah right sorry, I had the "Auto-Format on Save" enabled in VSCode, it removes the white space. Thanks for the merge, let's wait a week or so and then I might ask you again for another release, that bug is a deal-breaker for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resizeCanvasshould include preheader height, fixes #493 #497 was wrong and should be rolled back since the pre-header height is already calculated by getViewportHeight() which is called in the resizeCanvas() method.resizeCanvasshould include preheader height, fixes #493 #497 - ref resizeCanvas() does not take into account the preHeader height #493