-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gridMenu): add missing "headerColumnValueExtractor" to Grid Menu & fix #490 #491
fix(gridMenu): add missing "headerColumnValueExtractor" to Grid Menu & fix #490 #491
Conversation
- The "headerColumnValueExtractor" is especially useful when have Header Title Column Grouping if we want to include the title as part of the column picker of the Grid Menu
@6pac |
no probs, if they look uncontroversial and well thought out, which they usually are, I'm happy to just put them through. Also happy to do a release whenever. As I've probably said, I have a habit of waiting a few days after a PR is ready because often a few small issues pop up, but if you need them fast, let me know. |
Yup, as you can imagine I like to tests my code as much as I can ;) I'm expecting to release new version of my libs around mid next week, so if you could have a new release by then, that would be great, and so it doesn't have to be today if you wish to wait and take your time it's all good. |
@6pac I'll merge this PR and run some more tests on my side with all merged code of recent commits and then report back afterward. |
@6pac good thing I tried, I found a EDIT I fixed the problem, and explained it in there, in the next PR #500 ... oh wow we just reached 500, how lucky me lol |
headerColumnValueExtractor
is especially useful when having Header Title Column Grouping if we want to include the title as part of the column picker list within the Grid MenucontentMinWidth
grid menu optionuseClickToRepositionMenu
grid menu option, which use the click offset or the icon offset (when false) to reposition the grid menuWhen I created the Grid Menu control, I forgot to include the
headerColumnValueExtractor
function that the Column Picker already has, this is really helpful when having a grid with Column Header Title Grouping as can be seen below@6pac in case you're wondering, @ghiscoding-SE is my work GitHub account, I work for Schneider Electric, hence the SE ;)
BEFORE
AFTER