fix: horizontal scrolling can cause screen flickering #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add a delay of a cycle to avoid screen flickering that we observed to be worst in Chrome and Salesforce. This small delay of 1 cycle is enough to remove the flickering - the process is that when the grid is being scrolled horizontally, it has to change the scroll position of every other div container that might exist (preheader, headerrow, footer) and if we change the position at the same time as the grid scroll it can cause flickering
|
My only question here is are you trying to do rate limiting (ie. limiting the number of h scroll events that occur in a time period)? Otherwise, I'm not sure why the delay makes a difference. |
|
OK, sorry, looked a bit closer and I understand now. Good fix. |
|
done
B
From: "Ghislain B." ***@***.***>
Reply to: 6pac/SlickGrid ***@***.***>
Date: Friday, 3 February 2023 at 12:25 pm
To: 6pac/SlickGrid ***@***.***>
Cc: Ben McIntyre ***@***.***>, Mention ***@***.***>
Subject: Re: [6pac/SlickGrid] fix: horizontal scrolling can cause screen flickering (PR #722)
@6pac
a simple delay to avoid racing conditions and flickering, I think it's a very common problem in UI.
Could you also merge the other PR #716, I also got another one coming after that
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
ghiscoding
added a commit
that referenced
this pull request
Jun 30, 2023
- this PR simply rolls back PR #722
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The animated gif is not actually fast enough to catch the entire flickering, it's a lot worst for the user but it happens in millisecond and hard to catch by the recorder by annoying enough for human eyes. even if the gif is not showing the real flickering, it's enough to demonstrate the flickering we observed