-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The grid menu does not display properly when frozen columns are used with the grid menu #436
Comments
Does it work if you change the source code to This might give issues on regular grid though (when not using frozenColumn), I'm not sure what is the default of the grid option |
Have you tested with a regular grid (without any frozen)? |
Ok good, I'll do a fix later.. unless you want to create a PR (Pull Request) yourself? That would be nice. Thanks |
Ok, I will not create PR by myself for the time being. I will upgrade it after your official repair. At present, I temporarily solve this problem by changing the source code. |
fix(gridMenu): menu at wrong place when using Frozen Col 0, fixes #436
@ghiscoding If frozenColumn is set to 0, this judgment is problematic.For example, if(0) is actually false, then the judgment logic should be deleted, Please check the screenshot of my question, thank you |
oh damn I didn't catch that since you didn't mention it earlier. I'll fix that later today. |
- fixes the previous commit to fix the same issue, we should allow frozenColumns to be 0 or more and we should check that the frozenColumn property exist
I raised another PR, removing |
OK, you can also solve it in the following way, |
I already did another PR #439 and tested it locally |
OK,thanks |
fix(gridMenu): Menu should work with Frozen Col 0, fixes #436
When frozen column and grid menu are used together, the menu will be displayed in the left frozen column panel. This seems not normal. When I look at the source code, I find that it is caused by the following code logic
I only set frozenColumn to 0 because I only need to freeze the checkbox column
The text was updated successfully, but these errors were encountered: