Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the new onAutosizeColumn throw an "e" not defined error when calling autosizeColumns() #264

Closed
ghiscoding opened this issue Jul 25, 2018 · 3 comments

Comments

@ghiscoding
Copy link
Collaborator

ghiscoding commented Jul 25, 2018

@6pac
it looks like the last version with the new onAutosizeColumns throw an error

ERROR ReferenceError: e is not defined
    at SlickGrid.autosizeColumns (slick.grid.js:1330)

defined on this line

I think e should be used at all in this trigger as it doesn't seem to exist anywhere in autosizeColumns() function. I call autosize() with all my grids and this seems to break the grid, I'll have to go back to previous version since my grid doesn't get displayed at all with this error thrown

@ghiscoding ghiscoding changed the title the new onAutosizeColumn throw an "e" not defined error the new onAutosizeColumn throw an "e" not defined error when calling autosizeColumns() Jul 25, 2018
@claudiopetrini
Copy link

Same error here

@6pac
Copy link
Owner

6pac commented Jul 26, 2018

My bad. Cut and paste error. Fixed and re-released.
BTW, do we have an example file? Not quite sure how this is being used, in regard to testing.

Also, there was an autosize plugin #198, I assume that was a completely separate thing, as it seems to use fit-to-text-size.

@ghiscoding
Copy link
Collaborator Author

ghiscoding commented Jul 26, 2018

added a demo to test it, manually that is, see the related PR #265, thanks for fixing the bug so quickly

6pac added a commit that referenced this issue Jul 26, 2018
feat(demo): add demo for testing grid.autosizeColumns fn, ref #264
@6pac 6pac closed this as completed Jul 26, 2018
alhoo pushed a commit to alhoo/SlickGrid that referenced this issue Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants