Skip to content

Commit

Permalink
fix: auto-scroll should work even without jQueryUI (#703)
Browse files Browse the repository at this point in the history
- removing jQueryUI CSS from the auto-scroll example made it stopped working, after troubleshooting section by section, it only seem to be caused by an extra border around the slickgrid header. We can copy over the same border from jQueryUI into SlickGrid CSS and auto-scroll works again :)
  • Loading branch information
ghiscoding authored Oct 22, 2022
1 parent a001f1b commit 4e5397d
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 4 deletions.
1 change: 0 additions & 1 deletion examples/example-auto-scroll-when-dragging.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<link rel="shortcut icon" type="image/ico" href="favicon.ico" />
<title>SlickGrid example: Spreadsheet with Excel compatible cut and paste</title>
<link rel="stylesheet" href="../slick.grid.css" type="text/css"/>
<link rel="stylesheet" href="../css/smoothness/jquery-ui.css" type="text/css"/>
<link rel="stylesheet" href="examples.css" type="text/css"/>
<style>
.cell-effort-driven {
Expand Down
2 changes: 0 additions & 2 deletions examples/example-row-detail-selection-and-move.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<link rel="shortcut icon" type="image/ico" href="favicon.ico" />
<link rel="stylesheet" href="../slick.grid.css" type="text/css" />
<link rel="stylesheet" href="../css/smoothness/jquery-ui.css" type="text/css" />
<link rel="stylesheet" href="examples.css" type="text/css" />
<link rel="stylesheet" href="../controls/slick.columnpicker.css" type="text/css" />
<link rel="stylesheet" href="../plugins/slick.rowdetailview.css" type="text/css" />
Expand Down Expand Up @@ -121,7 +120,6 @@ <h3>Selected Titles:</h3>
<script src="../lib/firebugx.js"></script>

<script src="../lib/jquery-3.1.0.js"></script>
<script src="../lib/jquery-ui.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/sortablejs/Sortable.min.js"></script>

<script src="../slick.core.js"></script>
Expand Down
2 changes: 1 addition & 1 deletion slick.grid.css
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ classes should alter those!

.slick-header.ui-state-default {
overflow: inherit;
border-top: 1px solid #d3d3d3;
}

.slick-header::-webkit-scrollbar, .slick-headerrow::-webkit-scrollbar, .slick-footerrow::-webkit-scrollbar {
display: none
}
Expand Down

0 comments on commit 4e5397d

Please sign in to comment.