Skip to content

Commit

Permalink
[libc][thumb] support syscalls from thumb mode (llvm#96558)
Browse files Browse the repository at this point in the history
r7 is reserved in thumb2 (typically for the frame pointer, as opposed to r11 in
ARM mode), so assigning to a variable with explicit register storage in r7 will
produce an error.

But r7 is where the Linux kernel expects the syscall number to be placed. We
can use a temporary to get the register allocator to pick a temporary, which we
save+restore the previous value of r7 in.

Fixes: llvm#93738
  • Loading branch information
nickdesaulniers authored Jun 25, 2024
1 parent 0b049ce commit 4c87212
Showing 1 changed file with 19 additions and 7 deletions.
26 changes: 19 additions & 7 deletions libc/src/__support/OSUtil/linux/arm/syscall.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,29 @@
#include "src/__support/common.h"

#ifdef __thumb__
#error "The arm syscall implementation does not yet support thumb flavor."
#endif // __thumb__
#define R7 long r7 = number
#define SYSCALL_INSTR(input_constraint) \
int temp; \
LIBC_INLINE_ASM(R"(
mov %[temp], r7
mov r7, %2
svc #0
mov r7, %[temp]
)" \
: "=r"(r0), [temp] "=&r"(temp) \
: input_constraint \
: "memory", "cc")
#else
#define R7 register long r7 asm("r7") = number
#define SYSCALL_INSTR(input_constraint) \
LIBC_INLINE_ASM("svc 0" : "=r"(r0) : input_constraint : "memory", "cc")
#endif

#define REGISTER_DECL_0 \
register long r7 __asm__("r7") = number; \
R7; \
register long r0 __asm__("r0");
#define REGISTER_DECL_1 \
register long r7 __asm__("r7") = number; \
R7; \
register long r0 __asm__("r0") = arg1;
#define REGISTER_DECL_2 \
REGISTER_DECL_1 \
Expand All @@ -45,9 +60,6 @@
#define REGISTER_CONSTRAINT_5 REGISTER_CONSTRAINT_4, "r"(r4)
#define REGISTER_CONSTRAINT_6 REGISTER_CONSTRAINT_5, "r"(r5)

#define SYSCALL_INSTR(input_constraint) \
LIBC_INLINE_ASM("svc 0" : "=r"(r0) : input_constraint : "memory", "cc")

namespace LIBC_NAMESPACE {

LIBC_INLINE long syscall_impl(long number) {
Expand Down

0 comments on commit 4c87212

Please sign in to comment.