This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Fixes the issue reported in this comment:
#2720 (comment)
It wasn't only related to the create safe step, but in many places we were using a readOnly instance of web3. Most of the cases didn't had issues because it was not used to do queries to the blockchain but just for the unit conversion or parsing. But in those cases where we launch a query to the blockchain it was still initialized with the default chain RPC, so wrong RPC query was send in other chains
How this PR fixes it
We create a new instance of web3ReadOnly for each network, but we cache them as singleton instance in order to avoid creating many new objects
How to test it
Try to create a safe in a chain different than the default one and check that is correctly detected. Also RPC calls can be check in network console, validating that they are done to the correct chain RPC