Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Chore: Dont import react when not needed #2737

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Chore: Dont import react when not needed #2737

merged 1 commit into from
Sep 16, 2021

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Sep 16, 2021

What it solves

#2701 changed the ESLint configuration making it not necessary to import react to use JSX. What I didn't expect was that ESLint would treat an unused React import as an error

How this PR fixes it

by removing all unnecessary react imports across the app

How to test it

yarn build

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 19 0
Ignored 0 N/A
  • Result: ✅ success

  • Annotations: 19 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@katspaugh katspaugh merged commit 00c2ca1 into dev Sep 16, 2021
@katspaugh katspaugh deleted the bug/eslint-stuff branch September 16, 2021 09:11
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants